-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
fs: fix globSync traverse on allowed directory #61552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fs: fix globSync traverse on allowed directory #61552
Conversation
Fix an issue where fs.globSync failed to find files when read access was granted only for a certain directory via the --allow-fs-read flag. Fixes: nodejs#61499
94fba7f to
04e88bd
Compare
|
Also, while researching the issue, I discovered one thing: globSync uses
At the same time, in the asynch version of glob,
If a fix is indeed needed, I would be glad to work on it |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61552 +/- ##
=======================================
Coverage 89.77% 89.78%
=======================================
Files 672 672
Lines 203755 203756 +1
Branches 39167 39167
=======================================
+ Hits 182922 182938 +16
- Misses 13164 13167 +3
+ Partials 7669 7651 -18
🚀 New features to boost your workflow:
|
|
I'm going to check it as soon as possible. |
This will be fixed soon. Please, feel free to ignore the permission check for globSync then (add an commented test please). |
|
Okay, I see, but I’m not sure I understand which test needs to be added. The test for the problem of this issue itself is already part of this PR. |
Feel free to ignore the permission model test I asked for. If possible add a |


Fix an issue where fs.globSync failed to find files when read access was granted only for a certain directory via the --allow-fs-read flag.
Fixes: #61499